.github/workflows/css_check.py (2)

9-20: Expand Embedded CSS Detection Beyond Hex Codes

Right now, check_embedded_css only catches inline hex color usage (e.g., #FFF, #FFFFFF). If there are other forms of embedded styling (e.g., style attributes, inlined multi-line CSS, single-line style properties), they will remain undetected.

You might consider broadening the regex pattern or introducing multiple detection rules to cover other CSS constructs inlined in TypeScript files.

---

23-74: Enhance CSS Import Handling & Validation

1. Currently, the check for valid CSS imports is limited to endings with /app.module.css. You may want to allow for multiple valid module file names, for instance app.module.css or styles.module.css, based on your project guidelines or common naming conventions.

2. Consider whether you need to detect imports for .less, .scss, or .sass if the project supports them.

If the repository might evolve to use or allow multiple .module.* variations, you can update the condition to allow them or make it configurable.

.github/workflows/pull-request.yml (1)

42-42: Remove Trailing Whitespace

The lines added/modified at 42, 46, and 47 contain trailing spaces, as flagged by yamllint. Removing trailing whitespace will help maintain a clean and consistent YAML file.

Apply this diff:

42-      
42+
46-          
46+
47-          
47+

Also applies to: 46-46, 47-47

🧰 Tools

🪛 yamllint (1.35.1)

[error] 42-42: trailing spaces

(trailing-spaces)

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

.github/workflows/css_check.py (2)

58-58: Make test file exclusion configurable

The hardcoded exclusion of test files reduces flexibility.

Consider making test file exclusion configurable through command-line arguments:

-            if file.endswith((".ts", ".tsx")) and "test" not in root:
+            if file.endswith((".ts", ".tsx")) and not any(exclude in root for exclude in test_excludes):

Add to the argument parser:

parser.add_argument(
    "--test_excludes",
    nargs="*",
    default=["test", "__tests__"],
    help="Patterns to identify test directories"
)

---

99-117: Enhance error reporting and output format

The current output format could be improved for better integration with CI tools.

Consider adding:

1. JSON output format option
2. More detailed error statistics
3. Colored output for better readability

+    parser.add_argument(
+        "--output-format",
+        choices=["text", "json"],
+        default="text",
+        help="Output format (text or json)"
+    )

+    if args.output_format == "json":
+        import json
+        result = {
+            "violations": violations,
+            "embedded_css": embedded_css_violations,
+            "correct_imports": correct_css_imports,
+            "statistics": {
+                "files_checked": files_checked,
+                "violations_count": len(violations),
+                "embedded_css_count": len(embedded_css_violations)
+            }
+        }
+        print(json.dumps(result, indent=2))

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

.github/workflows/css_check.py (2)

11-23: Improve hex color code pattern matching

The pattern might match hex codes in comments or strings, leading to false positives.

Consider updating the pattern to exclude matches in comments and strings:

-    embedded_css_pattern = r"#([0-9a-fA-F]{3}){1,2}"  # Matches CSS color codes
+    # Exclude matches in single-line comments, multi-line comments, and strings
+    embedded_css_pattern = r'(?<!\/\/[^\n]*?)(?<!\/\*[\s\S]*?)(?<![\'"`])#([0-9a-fA-F]{3}){1,2}(?![0-9a-fA-F])'

---

70-72: Improve CSS import pattern matching

The current pattern might miss some valid import statements.

Consider updating the pattern to handle more import variations:

-                    r'import\s+.*?["\'](.*?\.css)["\'];', content
+                    r'import\s+(?:(?:{[^}]*}|\*|\w+)\s+from\s+)?["\'](.*?\.css)["\'];', content

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

Learnt from: IITI-tushar
PR: PalisadoesFoundation/talawa-admin#3041
File: .github/workflows/css_check.py:11-22
Timestamp: 2025-01-07T09:50:29.019Z
Learning: In the talawa-admin project, CSS validation in TypeScript files should only check for hex color codes using the pattern `#([0-9a-fA-F]{3}){1,2}` and ensure that files only reference the `src/style/app.module.css` stylesheet.